Hi Uwe,
On Thu, Jul 1, 2021 at 12:45 PM Uwe Kleine-König
<u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> On Thu, Jul 01, 2021 at 10:58:32AM +0200, Geert Uytterhoeven wrote:
> > On Thu, Jul 1, 2021 at 9:29 AM Uwe Kleine-König
> > <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> > > this is the successor of my earlier patch "pwm: Ensure for legacy
> > > drivers that pwm->state stays consistent" that was applied shortly to
> > > next until Geert found a problem with it.
> > >
> > > I split the patch in three parts now: First the legacy handling is just
> > > moved to a separate function without any semantic change. Then a glitch
> > > is fixed, but without the regression I introduced initially. In the
> > > third and last patch the longstanding FIXME about breaking pwm->state if
> > > a callback fails is addressed.
> > >
> > > Uwe Kleine-König (3):
> > > pwm: Move legacy driver handling into a dedicated function
> > > pwm: Prevent a glitch for legacy drivers
> > > pwm: Restore initial state if a legacy callback fails
> > >
> > > drivers/pwm/core.c | 139 ++++++++++++++++++++++++++-------------------
> > > 1 file changed, 79 insertions(+), 60 deletions(-)
> >
> > Thanks, works fine on Armadillo 800 EVA!
> > Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Thanks for testing.
>
> > > base-commit: 6efb943b8616ec53a5e444193dccf1af9ad627b5
> >
> > That's plain v5.13-rc1, which is probably not what Thierry is targeting?
>
> his for-next branch is based on v5.13-rc1 and there are no changes in it
> touching drivers/pwm/core.c, so I expect this to be fine.
Git tends to disagree:
$ git log --oneline v5.13-rc1..pwm/for-next -- drivers/pwm/core.c
9ae241d06ef7aca8 pwm: core: Simplify some devm_*pwm*() functions
c333b936c1530e76 pwm: core: Remove unused devm_pwm_put()
e625fb70a6d21e4d pwm: core: Unify fwnode checks in the module
e5c38ba9f2813beb pwm: core: Reuse fwnode_to_pwmchip() in ACPI case
ca06616b1eed3112 pwm: core: Convert to use fwnode for matching
ad5e085c63f59391 pwm: Drop irrelevant error path from pwmchip_remove()
bcda91bf86c1ff76 pwm: Add a device-managed function to add PWM chips
9e40ee18a1dc1623 pwm: core: Support new usage_power setting in PWM state
69230cfac3d02c1b pwm: Autodetect default value for of_pwm_n_cells from
device tree
5447e7833629ee42 pwm: Drop of_pwm_simple_xlate() in favour of
of_pwm_xlate_with_flags()
cf38c978cf1d2a28 pwm: Make of_pwm_xlate_with_flags() work with #pwm-cells = <2>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
