Hi Kieran, On Wed, Jun 23, 2021 at 11:06 AM Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx> wrote: > On 23/06/2021 04:46, Laurent Pinchart wrote: > > The R-Car MIPI DSI/CSI-2 TX is embedded in the Renesas R-Car V3U SoC. It > > can operate in either DSI or CSI-2 mode, with up to four data lanes. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > --- > > .../display/bridge/renesas,dsi-csi2-tx.yaml | 118 ++++++++++++++++++ > > 1 file changed, 118 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.yaml b/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.yaml > > new file mode 100644 > > index 000000000000..7e1b606a65ea > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.yaml > > @@ -0,0 +1,118 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/bridge/renesas,dsi-csi2-tx.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Renesas R-Car MIPI DSI/CSI-2 Encoder > > + > > +maintainers: > > + - Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > + > > +description: | > > + This binding describes the MIPI DSI/CSI-2 encoder embedded in the Renesas > > + R-Car V3U SoC. The encoder can operate in either DSI or CSI-2 mode, with up > > + to four data lanes. > > + > > +properties: > > + compatible: > > + enum: > > + - renesas,r8a779a0-dsi-csi2-tx # for V3U > > Only a potential nit ... > > Is it worth moving the "# for V3U" over a bit to allow for extended > compatibles in the future without re-aligning the table? > > Looks like 37 chars before it currently, it could at least move to > position 40. Happy predicting the future ;-) Did you take into account adding items and/or oneOf, which will impact alignment, too? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
