Hi Morimoto-san,
On Mon, May 17, 2021 at 2:36 AM Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
>
> Implement support for the ZA2 clock which is needed
> for R-Car Sound.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
Thanks for your patch!
> --- a/drivers/clk/renesas/r8a77995-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a77995-cpg-mssr.c
> @@ -35,6 +35,7 @@ enum clk_ids {
> CLK_PLL0D2,
> CLK_PLL0D3,
> CLK_PLL0D5,
> + CLK_PLL0D24,
> CLK_PLL1D2,
> CLK_PE,
> CLK_S0,
> @@ -62,6 +63,7 @@ static const struct cpg_core_clk r8a77995_core_clks[] __initconst = {
> DEF_FIXED(".pll0d2", CLK_PLL0D2, CLK_PLL0, 2, 1),
> DEF_FIXED(".pll0d3", CLK_PLL0D3, CLK_PLL0, 3, 1),
> DEF_FIXED(".pll0d5", CLK_PLL0D5, CLK_PLL0, 5, 1),
> + DEF_FIXED(".pll0d24", CLK_PLL0D24, CLK_PLL0, 24, 1),
> DEF_FIXED(".pll1d2", CLK_PLL1D2, CLK_PLL1, 2, 1),
> DEF_FIXED(".pe", CLK_PE, CLK_PLL0D3, 4, 1),
> DEF_FIXED(".s0", CLK_S0, CLK_PLL1, 2, 1),
> @@ -75,6 +77,7 @@ static const struct cpg_core_clk r8a77995_core_clks[] __initconst = {
> DEF_RATE(".oco", CLK_OCO, 8 * 1000 * 1000),
>
> /* Core Clock Outputs */
> + DEF_FIXED("za2", R8A77995_CLK_ZA2, CLK_PLL0D24, 1, 1),
This does not match the Hardware User's Manual (Rev. 2.20):
1. ZA2 is not a fixed clock, but can be controlled through the ZA2CKCR
register. Adding support for that requires writing a custom clock
driver.
Of course we can consider it a fixed clock initially, and make it
configurable later, when time permits.
2. The parent clock is either PLL0D3 or S0, with a configurable
post-divider of 2 or 4, yielding 200, 250, 400, or 500[*] MHz.
Using plain PLL0D24 would mean a post-divider of 8, yielding
125 MHz, which is not documented as a supported value.
[*] Using the default would mean:
DEF_FIXED("za2", R8A77995_CLK_ZA2, CLK_PLL0D3, 4, 1);
> DEF_FIXED("z2", R8A77995_CLK_Z2, CLK_PLL0D3, 1, 1),
> DEF_FIXED("ztr", R8A77995_CLK_ZTR, CLK_PLL1, 6, 1),
> DEF_FIXED("zt", R8A77995_CLK_ZT, CLK_PLL1, 4, 1),
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
