Re: [PATCH] clk: renesas: r9a06g032: Switch to .determine_rate()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Stephen,

On Thu, Apr 8, 2021 at 9:09 AM Stephen Boyd <sboyd@xxxxxxxxxx> wrote:
> Quoting Geert Uytterhoeven (2021-04-01 06:03:24)
> > diff --git a/drivers/clk/renesas/r9a06g032-clocks.c b/drivers/clk/renesas/r9a06g032-clocks.c
> > index 71b11443f6fc3801..c99942f0e4d4c751 100644
> > --- a/drivers/clk/renesas/r9a06g032-clocks.c
> > +++ b/drivers/clk/renesas/r9a06g032-clocks.c
> > @@ -630,11 +629,13 @@ r9a06g032_div_round_rate(struct clk_hw *hw,
> >         if (clk->index == R9A06G032_DIV_UART ||
> >             clk->index == R9A06G032_DIV_P2_PG) {
> >                 pr_devel("%s div uart hack!\n", __func__);
> > -               return clk_get_rate(hw->clk);
> > +               req->rate = clk_get_rate(hw->clk);
>
> Can this use clk_hw_get_rate()? Or it needs to be clk_get_rate() to make
> sure the rate doesn't change while querying the framework... from the
> framework? Another patch is preferred if you're interested in making the
> change.

Probably it can.  But as I don't have access to the hardware, I try to
be conservative.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux