On 05/03/2021 14:10, Geert Uytterhoeven wrote:
> Hi Kieran,
>
> On Thu, Mar 4, 2021 at 5:53 PM Kieran Bingham
> <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> wrote:
>> Three general purpose LEDs are provided on the Falcon CPU board.
>>
>> Connect GP_LED1, GP_LED2, and GP_LED3 to the gpio-leds frameworks.
>> These LEDs are arranged in a block of four LEDs on the board itself, but
>> the fourth LED is as yet unidentified.
>>
>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
>> --- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
>> +++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
>
> I believe the LEDs are on the CPU board, so they belong in
> r8a779a0-falcon-cpu.dtsi instead?
Yes, I hadn't quite grasped the layouts of this new board yet.
Sorry - I'll move it.
>
>> @@ -20,6 +20,20 @@ aliases {
>> chosen {
>> stdout-path = "serial0:115200n8";
>> };
>> +
>> + leds {
>> + compatible = "gpio-leds";
>> +
>> + led1 {
>> + gpios = <&gpio4 18 GPIO_ACTIVE_HIGH>;
>
> Any need for other properties from
> Documentation/devicetree/bindings/leds/common.yaml, like
> color = <LED_COLOR_ID_GREEN>?
Oh, I wasn't aware of those. But indeed the LED is green, so it seems
appropriate.
I'll test it out, and see if I can make it glow red (jokes).
>
>> + };
>> + led2 {
>> + gpios = <&gpio4 19 GPIO_ACTIVE_HIGH>;
>> + };
>> + led3 {
>> + gpios = <&gpio4 20 GPIO_ACTIVE_HIGH>;
>> + };
>> + };
>> };
>
> Gr{oetje,eeting}s,
>
> Geert
>
