Hi Kieran,
On Thu, Mar 4, 2021 at 5:53 PM Kieran Bingham
<kieran.bingham+renesas@xxxxxxxxxxxxxxxx> wrote:
> Three general purpose LEDs are provided on the Falcon CPU board.
>
> Connect GP_LED1, GP_LED2, and GP_LED3 to the gpio-leds frameworks.
> These LEDs are arranged in a block of four LEDs on the board itself, but
> the fourth LED is as yet unidentified.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts
I believe the LEDs are on the CPU board, so they belong in
r8a779a0-falcon-cpu.dtsi instead?
> @@ -20,6 +20,20 @@ aliases {
> chosen {
> stdout-path = "serial0:115200n8";
> };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + led1 {
> + gpios = <&gpio4 18 GPIO_ACTIVE_HIGH>;
Any need for other properties from
Documentation/devicetree/bindings/leds/common.yaml, like
color = <LED_COLOR_ID_GREEN>?
> + };
> + led2 {
> + gpios = <&gpio4 19 GPIO_ACTIVE_HIGH>;
> + };
> + led3 {
> + gpios = <&gpio4 20 GPIO_ACTIVE_HIGH>;
> + };
> + };
> };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
