Hi Wolfram, On Sun, Dec 27, 2020 at 1:19 PM Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote: > Because the datasheet is ambigious, copy over the reset values from the > latest BSP. > > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > --- > > While looking for a problem when obtaining the reset GPIO for RAVB, I > noticed this difference and so send this patch as a notification. It > sadly did not fix my RAVB problem, so I'll report it with the RAVB > patches there. I didn't find a map from "pfc-clocks" to "GPIO block" > yet, so this is all very confusing without it. AFAIUI, Table 6.2 ("Configuration of Registers in PFC") shows the grouping of the PFC/GPIO blocks, revealing the mapping from 4 module clocks to 4 groups of 2 or 4 GPIO blocks. > --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > @@ -110,7 +110,7 @@ gpio0: gpio@e6058180 { > interrupts = <GIC_SPI 832 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&cpg CPG_MOD 916>; > power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>; > - resets = <&cpg 916>; > + resets = <&cpg 1331>; I doubt the reset topology differs from the clock topology... Let's hope this will be clarified in a datasheet update soon. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds