On Mon, Dec 21, 2020 at 5:55 PM Ulrich Hecht <uli+renesas@xxxxxxxx> wrote: > Signed-off-by: Ulrich Hecht <uli+renesas@xxxxxxxx> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> One suggestion below... > --- a/drivers/pinctrl/renesas/sh_pfc.h > +++ b/drivers/pinctrl/renesas/sh_pfc.h > @@ -460,6 +460,11 @@ extern const struct sh_pfc_soc_info shx3_pinmux_info; > fn(bank, pin, GP_##bank##_##pin, sfx, cfg) > #define PORT_GP_1(bank, pin, fn, sfx) PORT_GP_CFG_1(bank, pin, fn, sfx, 0) > > +#define PORT_GP_CFG_2(bank, fn, sfx, cfg) \ > + PORT_GP_CFG_1(bank, 0, fn, sfx, cfg), \ > + PORT_GP_CFG_1(bank, 1, fn, sfx, cfg) > +#define PORT_GP_2(bank, fn, sfx) PORT_GP_CFG_2(bank, fn, sfx, 0) > + > #define PORT_GP_CFG_4(bank, fn, sfx, cfg) \ > PORT_GP_CFG_1(bank, 0, fn, sfx, cfg), \ > PORT_GP_CFG_1(bank, 1, fn, sfx, cfg), \ This can now start using PORT_GP_CFG_2(). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds