Hi Niklas,
On Mon, Sep 14, 2020 at 11:50:10PM +0200, Niklas Söderlund wrote:
> Use the fwnode_graph_get_endpoint_by_id() interface instead of
> of_graph_get_endpoint_by_regs() to fetch the fwnode. This saves
> translating between a device_node and fwnode_handle.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
Looks good
Reviewed-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
Thanks
j
> ---
> drivers/media/platform/rcar-vin/rcar-csi2.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c
> index 511cd4984777ad99..23e89ef2429d310a 100644
> --- a/drivers/media/platform/rcar-vin/rcar-csi2.c
> +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c
> @@ -873,31 +873,31 @@ static int rcsi2_parse_dt(struct rcar_csi2 *priv)
> {
> struct v4l2_async_subdev *asd;
> struct fwnode_handle *fwnode;
> - struct device_node *ep;
> + struct fwnode_handle *ep;
> struct v4l2_fwnode_endpoint v4l2_ep = { .bus_type = 0 };
> int ret;
>
> - ep = of_graph_get_endpoint_by_regs(priv->dev->of_node, 0, 0);
> + ep = fwnode_graph_get_endpoint_by_id(dev_fwnode(priv->dev), 0, 0, 0);
> if (!ep) {
> dev_err(priv->dev, "Not connected to subdevice\n");
> return -EINVAL;
> }
>
> - ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(ep), &v4l2_ep);
> + ret = v4l2_fwnode_endpoint_parse(ep, &v4l2_ep);
> if (ret) {
> dev_err(priv->dev, "Could not parse v4l2 endpoint\n");
> - of_node_put(ep);
> + fwnode_handle_put(ep);
> return -EINVAL;
> }
>
> ret = rcsi2_parse_v4l2(priv, &v4l2_ep);
> if (ret) {
> - of_node_put(ep);
> + fwnode_handle_put(ep);
> return ret;
> }
>
> - fwnode = fwnode_graph_get_remote_endpoint(of_fwnode_handle(ep));
> - of_node_put(ep);
> + fwnode = fwnode_graph_get_remote_endpoint(ep);
> + fwnode_handle_put(ep);
>
> dev_dbg(priv->dev, "Found '%pOF'\n", to_of_node(fwnode));
>
> --
> 2.28.0
>
