Re: [PATCH v3 3/4] soc: renesas: Merge if xxx into menu description

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Morimoto-san,

On Fri, Sep 4, 2020 at 2:03 AM Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
> > >  config ARCH_EMEV2
> > > -       bool "SoC Platform support for Emma Mobile EV2"
> > > +       bool "SoC Platform support for Emma Mobile EV2" if ARM && ARCH_RENESAS
> > >         select HAVE_ARM_SCU if SMP
> > >         select SYS_SUPPORTS_EM_STI
> >
> > I'm not convinced duplicating these dependencies is better than a
> > big #if block.  It does allow you to sort all SoCs alphabetically, but that
> > mixes ARM32 and ARM64 parts, while choosing between ARM32 and ARM64
> > is an early and important decision (different ARCH= and CROSS_COMPILE=,
> > too).
> > In addition, only one set of Kconfig options is shown to the user
> > anyway.
>
> OK, so let's keep big #if block.
> So how about to having
>         "ARM32 platform support ..." and
>         "ARM64 platform support" ?
> We can keep both #if block and alphabetical order

Yes, that looks fine to me. Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux