Hi Morimoto-san,
On Mon, Aug 24, 2020 at 4:22 AM Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
>
> Current Kconfig is using if - endif.
> This patch merges it into each menu description.
> This is prepare for menu sorting.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
Thanks for your patch!
> --- a/drivers/soc/renesas/Kconfig
> +++ b/drivers/soc/renesas/Kconfig
> @@ -44,17 +44,15 @@ config ARCH_RZN1
> bool
> select ARM_AMBA
>
> -if ARM && ARCH_RENESAS
> -
> #comment "Renesas ARM SoCs System Type"
>
> config ARCH_EMEV2
> - bool "SoC Platform support for Emma Mobile EV2"
> + bool "SoC Platform support for Emma Mobile EV2" if ARM && ARCH_RENESAS
> select HAVE_ARM_SCU if SMP
> select SYS_SUPPORTS_EM_STI
I'm not convinced duplicating these dependencies is better than a
big #if block. It does allow you to sort all SoCs alphabetically, but that
mixes ARM32 and ARM64 parts, while choosing between ARM32 and ARM64
is an early and important decision (different ARCH= and CROSS_COMPILE=,
too).
In addition, only one set of Kconfig options is shown to the user
anyway.
What do other people think?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
