Re: [PATCH 03/13] dt-bindings: media: ov5640: Do not limit rotation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 17, 2020 at 10:38:07PM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
> 
> Thank you for the patch.
> 
> On Fri, Jul 17, 2020 at 03:28:49PM +0200, Jacopo Mondi wrote:
> > The 'rotation' property should not be limited to only support 0 and
> > 180 degrees, as that limitation comes from the driver implementation
> > and not from any device specific constraint.
> > 
> > Remove the enumeration of supported values from 'rotation'.
> > 
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/media/i2c/ov5640.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ov5640.yaml b/Documentation/devicetree/bindings/media/i2c/ov5640.yaml
> > index ceeacc91c801..503f8b78615c 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/ov5640.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/ov5640.yaml
> > @@ -55,7 +55,7 @@ properties:
> >    rotation:
> >      description: |
> >        As defined in Documentation/devicetree/bindings/media/video-interfaces.txt
> > -    enum: [0, 180]
> > +    maxItems: 1

Not an array, so 'maxItems' doesn't make sense here.

> 
> Maybe
> 
>     $ref: /schemas/types.yaml#/definitions/uint32
>     minimum: 0
>     maximum: 359
> 
> ?

We should have a common definition and this binding just needs to define 
the specific constraints. If none, then just 'rotation: true'.

Rob



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux