Hi Jacopo, Thank you for the patch. On Fri, Jul 17, 2020 at 03:28:49PM +0200, Jacopo Mondi wrote: > The 'rotation' property should not be limited to only support 0 and > 180 degrees, as that limitation comes from the driver implementation > and not from any device specific constraint. > > Remove the enumeration of supported values from 'rotation'. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> > --- > Documentation/devicetree/bindings/media/i2c/ov5640.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov5640.yaml b/Documentation/devicetree/bindings/media/i2c/ov5640.yaml > index ceeacc91c801..503f8b78615c 100644 > --- a/Documentation/devicetree/bindings/media/i2c/ov5640.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/ov5640.yaml > @@ -55,7 +55,7 @@ properties: > rotation: > description: | > As defined in Documentation/devicetree/bindings/media/video-interfaces.txt > - enum: [0, 180] > + maxItems: 1 Maybe $ref: /schemas/types.yaml#/definitions/uint32 minimum: 0 maximum: 359 ? > > port: > type: object -- Regards, Laurent Pinchart