Hi Shimoda-san, On Fri, Jul 17, 2020 at 10:29 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote: > > From: Geert Uytterhoeven, Sent: Friday, July 17, 2020 4:13 PM > > On Fri, Jul 17, 2020 at 7:44 AM Yoshihiro Shimoda > > <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote: > > > > From: Geert Uytterhoeven, Sent: Wednesday, July 15, 2020 6:05 PM > > > > On Fri, Jul 10, 2020 at 2:03 PM Yoshihiro Shimoda > > > > <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote: > <snip> > > > > > arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 1 + > > > > > arch/arm64/boot/dts/renesas/salvator-common.dtsi | 1 + > > > > > > > > I assume we need this on other boards, too? > > > > At least ULCB uses the BD9571 PMIC, and has a similar PSCI s2ram > > > > implementation as Salvator-X(S) and Ebisu. > > > > > > I think so. And, I also thin ULCB+KF should not have this because > > > it doesn't support Suspend-to-RAM. But, what do you think? > > > > How come ULCB+KF doesn't support s2ram? > > Isn't KingFisher just an extension board for ULCB? > > Does it require a firmware upgrade? > > It's related to board design. If ULCB+KF, we must not use 5V AC to ULCB side > and must use 12V AC to KF side. And KF has power switch as SW6 for both ULCB+KF. > https://elinux.org/R-Car/Boards/Kingfisher OK. > However, PMIC on ULCB cannot control the KF power unfortunately. > So, we have no chance to use s2ram on ULCB+KF... Makes sense. BTW, what happens if you try s2ram? I guess the system just wakes up again immediately? Or does it crash? > > > JFYI, I could such environment if I added the property into ulcb.dtsi > > > and added "/delete-property/" into ulcb-kf.dtsi. > > > > Iff that's the case, that's a valid solution. > > I think that's a valid solution. But, what do you think? Thanks, looks good to me. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
