Hi Geert-san, > From: Geert Uytterhoeven, Sent: Wednesday, July 15, 2020 6:05 PM > > Hi Shimoda-san, > > On Fri, Jul 10, 2020 at 2:03 PM Yoshihiro Shimoda > <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote: > > Add full-pwr-cycle-in-suspend property to do a graceful shutdown of > > the eMMC device in system suspend. > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > > Thanks for your patch! > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > i.e. will queue in renesas-devel for v5.9. Thanks! > > arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 1 + > > arch/arm64/boot/dts/renesas/salvator-common.dtsi | 1 + > > I assume we need this on other boards, too? > At least ULCB uses the BD9571 PMIC, and has a similar PSCI s2ram > implementation as Salvator-X(S) and Ebisu. I think so. And, I also thin ULCB+KF should not have this because it doesn't support Suspend-to-RAM. But, what do you think? JFYI, I could such environment if I added the property into ulcb.dtsi and added "/delete-property/" into ulcb-kf.dtsi. Best regards, Yoshihiro Shimoda > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds