Re: [renesas-drivers:master 69/80] drivers/net/ethernet/sfc/efx_common.c:1232:19: sparse: sparse: incompatible types for operation (==):

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Edward.

On Wed, Jul 15, 2020 at 10:48 AM Edward Cree <ecree@xxxxxxxxxxxxxx> wrote:
> On 14/07/2020 19:56, Bjorn Helgaas wrote:
> > [+cc Luc, linux-pci]
> >
> > I think what's necessary here is to replace "enum pci_channel_state
> > state" with "pci_channel_state_t state", as in 16d79cd4e23b ("PCI: Use
> > 'pci_channel_state_t' instead of 'enum pci_channel_state'"):
> >
> > https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?id=16d79cd4e23b
> >
> > This change should be safe even without 16d79cd4e23b, so there won't
> > be a revlock if you make it in the renesas-drivers tree.
> This is presumably goingto happen in any tree that pulls both net-next
>  and pci/next.  So shouldn't we make the change in net-next, rather than
>  in a renesas tree that really has little to do with it other than being
>  the first place the problem showed up?

Indeed, it should be fixed at the core, not in an integration testing tree.
BTW, did it show up in linux-next, too, or have I done a bad merge conflict
resolution?

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux