Hi Wolfram, On Mon, Jun 29, 2020 at 1:21 PM Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote: > > > config I2C_SLAVE > > > bool "I2C slave support" > > > > > > > Why the blank line here ^^^? > > Sure, I can fix before applying. > > > > > > + help > > > + This enables Linux to act as an I2C slave device. Note that your I2C > > > + bus master driver also needs to support this functionality. Please > > > + read Documentation/i2c/slave-interface.rst for further details. > > > + > > > if I2C_SLAVE > > > > > > config I2C_SLAVE_EEPROM > > > > The rest looks fine to me. > > Thanks, Geert! > > > As you don't like conditional R-b's, I'll add mine on v2 ;-) > > I don't? I can't recall that :) Maybe there was a corner case once... Lore does not forgive, and does not forget ;-) https://lore.kernel.org/r/20190802133656.GA23542@kunai Hence with the above fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
