Hi Wolfram,
On Sun, Jun 28, 2020 at 8:55 PM Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> I can't recall why there was none, but we surely want to have it.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
Thanks for your patch!
> --- a/drivers/i2c/Kconfig
> +++ b/drivers/i2c/Kconfig
> @@ -114,6 +114,11 @@ config I2C_STUB
> config I2C_SLAVE
> bool "I2C slave support"
>
Why the blank line here ^^^?
> + help
> + This enables Linux to act as an I2C slave device. Note that your I2C
> + bus master driver also needs to support this functionality. Please
> + read Documentation/i2c/slave-interface.rst for further details.
> +
> if I2C_SLAVE
>
> config I2C_SLAVE_EEPROM
The rest looks fine to me.
As you don't like conditional R-b's, I'll add mine on v2 ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
