Hi Sergei, On Mon, Jun 22, 2020 at 10:04 PM Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > On 06/21/2020 11:17 AM, Geert Uytterhoeven wrote: > > Convert the Renesas Ethernet AVB (EthernetAVB-IF) Device Tree binding > > documentation to json-schema. > > > > Add missing properties. > > Update the example to match reality. > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > As I'm only seeing the formatting issues, here's my: > > Reviewed-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> Thank you! > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml > > @@ -0,0 +1,269 @@ > [...] > > +maintainers: > > + - Sergei Shtylyov <sergei.shtylyov@xxxxxxxxx> > > Thank you! :-) You're (very) welcome ;-) > > > + > > +properties: > > + compatible: > > + oneOf: > > + - items: > > + - enum: > > + - renesas,etheravb-r8a7742 # RZ/G1H > > + - renesas,etheravb-r8a7743 # RZ/G1M > > + - renesas,etheravb-r8a7744 # RZ/G1N > > + - renesas,etheravb-r8a7745 # RZ/G1E > > + - renesas,etheravb-r8a77470 # RZ/G1C > > + - renesas,etheravb-r8a7790 # R-Car H2 > > + - renesas,etheravb-r8a7791 # R-Car M2-W > > + - renesas,etheravb-r8a7792 # R-Car V2H > > + - renesas,etheravb-r8a7793 # R-Car M2-N > > + - renesas,etheravb-r8a7794 # R-Car E2 > > Hm, overindented starting with "- items:"? I believe this is consistent with e.g. commit 9f60a65bc5e6cd88 ("dt-bindings: Clean-up schema indentation formatting"). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds