Hello! On 06/21/2020 11:17 AM, Geert Uytterhoeven wrote: > Convert the Renesas Ethernet AVB (EthernetAVB-IF) Device Tree binding > documentation to json-schema. > > Add missing properties. > Update the example to match reality. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> As I'm only seeing the formatting issues, here's my: Reviewed-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> > diff --git a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml > new file mode 100644 > index 0000000000000000..c87d8c6389328eaa > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml > @@ -0,0 +1,269 @@ [...] > +maintainers: > + - Sergei Shtylyov <sergei.shtylyov@xxxxxxxxx> Thank you! :-) > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - renesas,etheravb-r8a7742 # RZ/G1H > + - renesas,etheravb-r8a7743 # RZ/G1M > + - renesas,etheravb-r8a7744 # RZ/G1N > + - renesas,etheravb-r8a7745 # RZ/G1E > + - renesas,etheravb-r8a77470 # RZ/G1C > + - renesas,etheravb-r8a7790 # R-Car H2 > + - renesas,etheravb-r8a7791 # R-Car M2-W > + - renesas,etheravb-r8a7792 # R-Car V2H > + - renesas,etheravb-r8a7793 # R-Car M2-N > + - renesas,etheravb-r8a7794 # R-Car E2 Hm, overindented starting with "- items:"? > + - const: renesas,etheravb-rcar-gen2 # R-Car Gen2 and RZ/G1 > + > + - items: > + - enum: > + - renesas,etheravb-r8a774a1 # RZ/G2M > + - renesas,etheravb-r8a774b1 # RZ/G2N > + - renesas,etheravb-r8a774c0 # RZ/G2E > + - renesas,etheravb-r8a7795 # R-Car H3 > + - renesas,etheravb-r8a7796 # R-Car M3-W > + - renesas,etheravb-r8a77961 # R-Car M3-W+ > + - renesas,etheravb-r8a77965 # R-Car M3-N > + - renesas,etheravb-r8a77970 # R-Car V3M > + - renesas,etheravb-r8a77980 # R-Car V3H > + - renesas,etheravb-r8a77990 # R-Car E3 > + - renesas,etheravb-r8a77995 # R-Car D3 > + - const: renesas,etheravb-rcar-gen3 # R-Car Gen3 and RZ/G2 Here as well... [...] > +allOf: > + - $ref: ethernet-controller.yaml# > + > + - if: > + properties: Overindented? > + compatible: > + contains: > + enum: > + - renesas,etheravb-rcar-gen2 > + - renesas,etheravb-r8a7795 > + - renesas,etheravb-r8a7796 > + - renesas,etheravb-r8a77961 > + - renesas,etheravb-r8a77965 [...] > + - if: > + properties: Overindented? > + - if: > + properties: Overindented? > + compatible: > + contains: > + const: renesas,etheravb-r8a77995 > + then: > + properties: > + renesas,rxc-delay-ps: > + const: 1800 > + > + - if: > + properties: Overindented? [...] MBR, Sergei
