Hi Wolfram-san, > From: wsa+renesas@xxxxxxxxxxxxxxxxxxxx, Sent: Tuesday, June 2, 2020 9:52 PM > > Hi Shimoda-san, > > thanks for the patches and for providing a test case. I was not able to > reproduce the issue, though. I'll explain... Thank you for trying to reproduce the issue! > > Note that this patch series is tested by using additional debug code [1], > > because there is difficult to reproduce this issue. Before apply patch, > > When I enabled CONFIG_DMA_API_DEBUG and CONFIG_DMA_API_DEBUG_SG, > > I observed lacking dma unmapping on /sys/kernel/debug/dma-api/dump. > > And then I confirmed the patch can fix the issue. > > So, I have this debug patch applied on top of mmc/next. I have the above > CONFIG_ symbols enabled. I have _not_ applied your three patches which > fix the issue. I mounted the eMMC and read a large file. I see the > injected timeouts happening: > > [ 94.079560] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle > [ 94.088668] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle > [ 94.097727] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle > [ 94.106768] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle > [ 94.115848] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle > [ 99.300589] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for hardware interrupt (CMD13) > > But I do not see any output from the DMA debug system about a missing > unmapping. I expected that, though, because your fixes are not applied. > The testfile could even be correctly checksummed after reading, just > awfully slow, of course. I'm sorry, I should have shared my log. My test case is: - Use dd command as background. - Read /sys/kernel/debug/dma-api/dump while the dd command is running. --> "ee140000.sd" lines are increased gradually. ---- Log --- ~ # dd if=/dev/mmcblk1 of=/dev/null bs=512k & ~ # grep sd /sys/kernel/debug/dma-api/dump ee140000.sd renesas_sdhi_internal_dmac scather-gather idx 8274 P=736a8a000 N=736a8a D=740a4000 L=3000 DMA_FROM_DEVICE dma map error check not applicable ee140000.sd renesas_sdhi_internal_dmac scather-gather idx 8603 P=736a51000 N=736a51 D=74337000 L=1000 DMA_FROM_DEVICE dma map error check not applicable ~ # [ 56.797275] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for hardware interrupt (CMD13) [ 56.857055] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle [ 56.866231] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle [ 56.875330] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle [ 56.884313] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle [ 56.893334] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle [ 61.917228] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for hardware interrupt (CMD13) [ 61.967599] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle [ 61.976722] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle [ 61.985726] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle [ 61.994847] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle [ 62.003772] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle ~ # ~ # [ 67.037259] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for hardware interrupt (CMD13) [ 67.098616] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle [ 67.107610] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle [ 67.116595] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle [ 67.125591] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle [ 67.134819] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle ~ # ~ # grep sd /sys/kernel/debug/dma-api/dump ee140000.sd renesas_sdhi_internal_dmac scather-gather idx 8274 P=736a8a000 N=736a8a D=740a4000 L=3000 DMA_FROM_DEVICE dma map error check not applicable ee140000.sd renesas_sdhi_internal_dmac scather-gather idx 8603 P=736a51000 N=736a51 D=74337000 L=1000 DMA_FROM_DEVICE dma map error check not applicable ee140000.sd renesas_sdhi_internal_dmac scather-gather idx 8807 P=737c2c000 N=737c2c D=744ce000 L=1000 DMA_FROM_DEVICE dma map error check not applicable ee140000.sd renesas_sdhi_internal_dmac scather-gather idx 8993 P=736b80000 N=736b80 D=74642000 L=1000 DMA_FROM_DEVICE dma map error check not applicable ee140000.sd renesas_sdhi_internal_dmac scather-gather idx 9251 P=73665f000 N=73665f D=74847000 L=1000 DMA_FROM_DEVICE dma map error check not applicable ~ # [ 72.157278] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for hardware interrupt (CMD13) [ 72.217556] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle [ 72.226595] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle [ 72.235577] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle [ 72.244558] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle [ 72.253580] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle [ 77.277235] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for hardware interrupt (CMD13) [ 77.339935] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle [ 77.348953] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle [ 77.358283] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle [ 77.367271] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle [ 77.376215] renesas_sdhi_internal_dmac ee140000.sd: timeout waiting for SD bus idle ~ # ~ # grep sd /sys/kernel/debug/dma-api/dump ee140000.sd renesas_sdhi_internal_dmac scather-gather idx 8274 P=736a8a000 N=736a8a D=740a4000 L=3000 DMA_FROM_DEVICE dma map error check not applicable ee140000.sd renesas_sdhi_internal_dmac scather-gather idx 8603 P=736a51000 N=736a51 D=74337000 L=1000 DMA_FROM_DEVICE dma map error check not applicable ee140000.sd renesas_sdhi_internal_dmac scather-gather idx 8807 P=737c2c000 N=737c2c D=744ce000 L=1000 DMA_FROM_DEVICE dma map error check not applicable ee140000.sd renesas_sdhi_internal_dmac scather-gather idx 8993 P=736b80000 N=736b80 D=74642000 L=1000 DMA_FROM_DEVICE dma map error check not applicable ee140000.sd renesas_sdhi_internal_dmac scather-gather idx 9251 P=73665f000 N=73665f D=74847000 L=1000 DMA_FROM_DEVICE dma map error check not applicable ee140000.sd renesas_sdhi_internal_dmac scather-gather idx 9470 P=739af2000 N=739af2 D=749fc000 L=1000 DMA_FROM_DEVICE dma map error check not applicable ee140000.sd renesas_sdhi_internal_dmac scather-gather idx 9794 P=736867000 N=736867 D=74c85000 L=1000 DMA_FROM_DEVICE dma map error check not applicable ---- Best regards, Yoshihiro Shimoda
