[+cc Lorenzo]
On Sat, Apr 25, 2020 at 10:55:21AM +0200, Geert Uytterhoeven wrote:
> On Fri, Apr 24, 2020 at 9:57 PM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
> > [+cc Vaibhav]
> >
> > Alternate less redundant subject:
> >
> > PCI: rcar: Add suspend/resume support
>
> Note that there's both pcie-rcar.c (this driver, for R-Car Gen2 and Gen3
> PCIe) and pci-rcar-gen2.c (for R-Car Gen2 PCI).
> People tend to use the prefix "PCI: rcar: " for both :-(
Yeah, that's pretty broken, thanks for pointing this out!
For most drivers we use a chipset name ("keystone", "imx6", "tegra",
etc) as the changlog tag. That's nice because it gives space for
multiple drivers from the same vendor, but I don't know anything
similarly specific for the R-Car drivers.
pci-rcar-gen2.c seems to be for some sort of internal Conventional PCI
bus? The "gen2" is confusing because "Gen 2" is more commonly used
for PCIe than for Conventional PCI.
I would propose keeping "rcar" for the PCIe driver and using
"rcar-pci" for the Conventional PCI one, but the Conventional PCI one
(pci-rcar-gen2.c) seems pretty inactive. The most recent commits are
from 2018, and they're trivial cleanups. So I'm doubtful that anybody
will remember when the next change comes in.
Bjorn
