On 4/27/20 6:44 PM, Bjorn Helgaas wrote:
> On Sun, Apr 26, 2020 at 02:31:15PM +0200, marek.vasut@xxxxxxxxx wrote:
>> From: Marek Vasut <marek.vasut+renesas@xxxxxxxxx>
>>
>> If CONFIG_PM_SLEEP is not set, SET_SYSTEM_SLEEP_PM_OPS() is expanded to
>> empty macro and there is no reference to rcar_pcie_resume(), hence the
>> following warning is generated:
>>
>> drivers/pci/controller/pcie-rcar.c:1253:12: warning: ‘rcar_pcie_resume’ defined but not used [-Wunused-function]
>> 1253 | static int rcar_pcie_resume(struct device *dev)
>> | ^~~~~~~~~~~~~~~~
>>
>> Fix this by marking this function as __maybe_unused , just like in
>> commit 226e6b866d74 ("gpio: pch: Convert to dev_pm_ops")
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx>
>> Reported-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
>> Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
>> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>
>> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>> Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx>
>> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx
>> ---
>> NOTE: Based on git://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git
>> branch pci/rcar
>> NOTE: The driver tag is now 'pcie-rcar' to distinguish it from pci-rcar-gen2.c
>
> I hope Lorenzo will squash this into the original commit. I don't
> think it adds anything useful to keep it as a separate commit.
Fine by me, that's also why I added these notes, so it's obvious it's
based off the same branch where the previous patch is already.
