On 3/20/20 11:12 AM, Lorenzo Pieralisi wrote:
[...]
>> +static int rcar_pcie_resume(struct device *dev)
>> +{
>> + struct rcar_pcie *pcie = dev_get_drvdata(dev);
>> + int (*hw_init_fn)(struct rcar_pcie *);
>> + unsigned int data;
>> + int err;
>> +
>> + err = rcar_pcie_parse_map_dma_ranges(pcie);
>> + if (err)
>> + return 0;
>> +
>> + /* Failure to get a link might just be that no cards are inserted */
>> + hw_init_fn = of_device_get_match_data(dev);
>
> Hi Marek,
Hi,
> happy to apply it as is, I was wondering if it is work taking this
> look-up out of the resume path, it is not supposed to change anyway,
> you can even save the function pointer at probe.
>
> Again, happy to apply it as-is, just let me know please.
I just sent subsequent patch to address this:
PCI: pcie-rcar: Cache PHY init function pointer
