On 4/24/20 9:57 PM, Bjorn Helgaas wrote:
Hi,
[...]
>> @@ -1234,6 +1295,7 @@ static int rcar_pcie_resume_noirq(struct device *dev)
>> }
>>
>> static const struct dev_pm_ops rcar_pcie_pm_ops = {
>> + SET_SYSTEM_SLEEP_PM_OPS(NULL, rcar_pcie_resume)
>
> This causes the following warning when CONFIG_PM_SLEEP is not set:
>
> drivers/pci/controller/pcie-rcar.c:1253:12: warning: ‘rcar_pcie_resume’ defined but not used [-Wunused-function]
> 1253 | static int rcar_pcie_resume(struct device *dev)
> | ^~~~~~~~~~~~~~~~
>
> Most people seem to be using __maybe_unused on the suspend/resume
> functions to avoid this, e.g., 226e6b866d74 ("gpio: pch: Convert to
> dev_pm_ops").
Should be fixed by:
PCI: pcie-rcar: Mark rcar_pcie_resume() with __maybe_unused
