Hi Sato-san, Rich These are strncpy() fixup patches, but using different solutions. Karl's patches are updating current strncpy(), but using 2 patterns. Kuninori's patch is using generic strncpy(). We don't know which is the best, but we can follow SH maintainer's selection. Karl Nasrallah (2): sh: fixup strncpy() warning and add missing padding sh: fixup strncpy() warning and add missing padding Kuninori Morimoto (4): sh: use generic strncpy() Thank you for your help !! Best regards --- Kuninori Morimoto