Hello, On Wed, Dec 11, 2019 at 12:59:57PM +0000, Kieran Bingham wrote: > Hi Morimoto-san, > > Thank you for the patch, Likewise :-) > On 11/12/2019 01:55, Kuninori Morimoto wrote: > > > > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > > > The address of VSP2_VI6_HGT_LBx_H are > > VSP2_VI6_HGT_LB0_H : 0x3428 > > VSP2_VI6_HGT_LB1_H : 0x3430 > > VSP2_VI6_HGT_LB2_H : 0x3438 > > VSP2_VI6_HGT_LB3_H : 0x3440 > > > > Thus, VI6_HGT_LBn_H() macro should start from 0x3420 instead of 0x3430. > > This patch fixup it. > > I think this deserves a fixes tag: > > Fixes: 26e0ca22c3b8 ("[media] v4l: Renesas R-Car VSP1 driver") Given that this macro is not used, we could argue that it doesn't fix anything yet :-) I'd rather avoid having this backported to stable kernels as it's not useful to have it there, and thus not add a Fixes tag. Kieran, would that be OK with you ? > > Reported-by: Koji Matsuoka <koji.matsuoka.xm@xxxxxxxxxxx> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > Otherwise, > > Yes I can clearly see that this offset is marked as H'3428 at page 32-39 > within the Gen3 datasheet. > > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> and taken in my branch. > > --- > > drivers/media/platform/vsp1/vsp1_regs.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/platform/vsp1/vsp1_regs.h b/drivers/media/platform/vsp1/vsp1_regs.h > > index 5c67ff9..fe3130d 100644 > > --- a/drivers/media/platform/vsp1/vsp1_regs.h > > +++ b/drivers/media/platform/vsp1/vsp1_regs.h > > @@ -706,7 +706,7 @@ > > #define VI6_HGT_HUE_AREA_LOWER_SHIFT 16 > > #define VI6_HGT_HUE_AREA_UPPER_SHIFT 0 > > #define VI6_HGT_LB_TH 0x3424 > > -#define VI6_HGT_LBn_H(n) (0x3438 + (n) * 8) > > +#define VI6_HGT_LBn_H(n) (0x3428 + (n) * 8) > > #define VI6_HGT_LBn_V(n) (0x342c + (n) * 8) > > #define VI6_HGT_HISTO(m, n) (0x3450 + (m) * 128 + (n) * 4) > > #define VI6_HGT_MAXMIN 0x3750 -- Regards, Laurent Pinchart