Hi Jacopo,
One minor additional catch here:
On 15/10/2019 12:53, Kieran Bingham wrote:
> Hi Jacopo,
<snipped>
>> +
>> +/*
>> + * rcar_cmm_lut_write() - Scale the DRM LUT table entries to hardware precision
>> + * and write to the CMM registers.
>> + * @rcmm: Pointer to the CMM device
>> + * @drm_lut: Pointer to the DRM LUT table
>> + */
>> +static void rcar_cmm_lut_write(struct rcar_cmm *rcmm,
>> + const struct drm_color_lut *drm_lut)
>> +{
>> + unsigned int i;
>> +
>> + for (i = 0; i < CM2_LUT_SIZE; ++i) {
>> + u32 entry = drm_color_lut_extract(drm_lut[i].red, 8) << 16
There's an extra space between = and 'drm_color...' here.
<snipped>
--
Kieran
