Hi Biju, On Fri, Sep 20, 2019 at 4:54 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > On Thu, Sep 19, 2019 at 10:17 AM Biju Das <biju.das@xxxxxxxxxxxxxx> wrote: > > Add support for RZ/G2N (R8A774B1) SoC power areas to the R-Car SYSC > > driver. > > > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx> > > --- /dev/null > > +++ b/drivers/soc/renesas/r8a774b1-sysc.c > > +const struct rcar_sysc_info r8a774b1_sysc_info __initconst = { > > + .areas = r8a774b1_areas, > > + .num_areas = ARRAY_SIZE(r8a774b1_areas), > > Given the Hardware User's Manual documents the presence of the SYSCEXTMASK > register on RZ/G2N, you want to fill in the .extmask_{offs,val} fields, too. FTR: I'm looking at Rev. 0.80 of the manual. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds