Hi Biju-san,
Thank you for the patch!
> From: Biju Das, Sent: Wednesday, May 15, 2019 9:09 PM
>
> Add device tree binding document for TI HD3SS3220 Type-C DRP port
> controller driver.
>
> Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> V5-->V6
> * No change.
> V4-->V5
> * No Change.
> V3-->V4
> * No Change.
> V2-->V3
> * Added Rob's Reviewed by tag.
> V1-->V2
> * Added connector node.
> * updated the example with connector node.
> ---
> .../devicetree/bindings/usb/ti,hd3ss3220.txt | 37 ++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/ti,hd3ss3220.txt
>
> diff --git a/Documentation/devicetree/bindings/usb/ti,hd3ss3220.txt
> b/Documentation/devicetree/bindings/usb/ti,hd3ss3220.txt
> new file mode 100644
> index 0000000..7f41400
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ti,hd3ss3220.txt
> @@ -0,0 +1,37 @@
> +TI HD3SS3220 TypeC DRP Port Controller.
> +
> +Required properties:
> + - compatible: Must be "ti,hd3ss3220".
> + - reg: I2C slave address, must be 0x47 or 0x67 based on ADDR pin.
> + - interrupts: <a b> where a is the interrupt number and b represents an
> + encoding of the sense and level information for the interrupt.
> +
> +Required sub-node:
> + - connector : The "usb-c-connector" attached to the hd3ss3220 chip. The
s/connector :/connector:/
> + bindings of the connector node are specified in:
> +
> + Documentation/devicetree/bindings/connector/usb-connector.txt
> +
> +Example:
> +hd3ss3220@47 {
> + compatible = "ti,hd3ss3220";
> + reg = <0x47>;
> + interrupt-parent = <&gpio6>;
> + interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> +
> + usb_con: connector {
> + compatible = "usb-c-connector";
> + label = "USB-C";
> + data-role = "dual";
> + };
> +
> + port {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + hd3ss3220_ep: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&usb3peri_role_switch>;
> + };
> + };
According to the connector/usb-connector.txt, should the connector node
have ports, port@1 and an endpoint nodes like below?
usb_con: connector {
compatible = "usb-c-connector";
label = "USB-C";
data-role = "dual";
ports {
#address-cells = <1>;
#size-cells = <0>;
port@1 {
reg = <1>;
hd3ss3220_ep: endpoint {
remote-endpoint = <&usb3peri_role_switch>;
};
};
};
};
Best regards,
Yoshihiro Shimoda
