On 5/3/19 8:13 PM, Geert Uytterhoeven wrote:
> Hi Marek,
Hi,
> On Fri, May 3, 2019 at 5:18 PM Marek Vasut <marek.vasut@xxxxxxxxx> wrote:
>> On 5/3/19 2:36 PM, Geert Uytterhoeven wrote:
>>>> &rwdt {
>>>> @@ -309,6 +314,8 @@
>>>> };
>>>>
>>>> &iic3 {
>>>> + pinctrl-names = "default";
>>>> + pinctrl-0 = <&pmic_irq_pins>;
>>>
>>> Given Blanche has a single device connected to irq2, I think it makes
>>> sense to move the pinctrl properties to the pmic node below.
>>
>> It makes blanche somehow inconsistent with the other boards, but if you
>> insist ... ?
>
> Typically the pinctrl properties are part of the device node that uses them.
> For the other boards, that's not possible, as they are shared by all PMIC
> nodes. Hence the other boards are the exceptions, actually ;-)
>
> Note that for multi-PMIC boards, adding the pinctrl properties to a single
> PMIC node won't work, as that would break:
> 1. The case where the driver for that PMIC is not compiled in,
> 2. The R-Car Gen2 regulator quirk.
Well it wouldn't work because it's shared by two PMICs and thus two
driver instances in the first place.
--
Best regards,
Marek Vasut
