Hi Marek,
On Thu, May 2, 2019 at 4:06 PM <marek.vasut@xxxxxxxxx> wrote:
> From: Marek Vasut <marek.vasut+renesas@xxxxxxxxx>
>
> The PMIC IRQ line pin multiplexing configuration is missing from the DTs.
> Since the line is configured correctly by default, the system works fine.
> However, add the IRQ line pin multiplexing configuration for completeness.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx>
Thanks for your patch!
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -423,6 +423,8 @@
> */
> i2cpwr: i2c-13 {
> compatible = "i2c-demux-pinctrl";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pmic_irq_pins>;
> i2c-parent = <&iic3>, <&i2c3>;
> i2c-bus-name = "i2c-pwr";
> #address-cells = <1>;
> @@ -615,6 +617,11 @@
> function = "iic3";
> };
>
> + pmic_irq_pins: pmicirq {
> + groups = "intc_irq2";
> + function = "intc";
> + };
Please insert according to alphabetical sort order.
Oh, we don't have the R-Car Gen2 entries sorted yet. Nevermind...
> --- a/arch/arm/boot/dts/r8a7792-blanche.dts
> +++ b/arch/arm/boot/dts/r8a7792-blanche.dts
> @@ -234,6 +234,11 @@
> groups = "du1_rgb666", "du1_sync", "du1_disp";
> function = "du1";
> };
> +
> + pmic_irq_pins: pmicirq {
> + groups = "intc_irq2";
> + function = "intc";
> + };
> };
>
> &rwdt {
> @@ -309,6 +314,8 @@
> };
>
> &iic3 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pmic_irq_pins>;
Given Blanche has a single device connected to irq2, I think it makes
sense to move the pinctrl properties to the pmic node below.
With that fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
