Hi Sergei,
On Tue, Apr 30, 2019 at 10:12 AM Sergei Shtylyov
<sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote:
> On 29.04.2019 18:20, Geert Uytterhoeven wrote:
> > There is no need to print a message if devm_kzalloc() or
>
> Just kzalloc() in this case.
Thanks, silly copy-and-paste error.
> > --- a/drivers/irqchip/irq-renesas-irqc.c
> > +++ b/drivers/irqchip/irq-renesas-irqc.c
> > @@ -173,7 +172,6 @@ static int irqc_probe(struct platform_device *pdev)
> > /* ioremap IOMEM and setup read/write callbacks */
> > p->iomem = ioremap_nocache(io->start, resource_size(io));
> > if (!p->iomem) {
> > - dev_err(&pdev->dev, "failed to remap IOMEM\n");
> > ret = -ENXIO;
>
> -ENOMEM?
I'd say yes, except that this error code is removed in patch [5/5], so I don't
think it's worth changing it in this patch.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
