Re: [PATCH 2/5] irqchip/renesas-irqc: Remove devm_kzalloc()/ioremap_nocache() error printing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello!

On 29.04.2019 18:20, Geert Uytterhoeven wrote:

There is no need to print a message if devm_kzalloc() or

   Just kzalloc() in this case.

ioremap_nocache() fails, as the memory allocation core already takes
care of that.

Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
---
  drivers/irqchip/irq-renesas-irqc.c | 2 --
  1 file changed, 2 deletions(-)

diff --git a/drivers/irqchip/irq-renesas-irqc.c b/drivers/irqchip/irq-renesas-irqc.c
index 438a063c76156d98..0955ffe12b32eb36 100644
--- a/drivers/irqchip/irq-renesas-irqc.c
+++ b/drivers/irqchip/irq-renesas-irqc.c
@@ -133,7 +133,6 @@ static int irqc_probe(struct platform_device *pdev)
p = kzalloc(sizeof(*p), GFP_KERNEL);
  	if (!p) {
-		dev_err(&pdev->dev, "failed to allocate driver data\n");
  		ret = -ENOMEM;
  		goto err0;
  	}
@@ -173,7 +172,6 @@ static int irqc_probe(struct platform_device *pdev)
  	/* ioremap IOMEM and setup read/write callbacks */
  	p->iomem = ioremap_nocache(io->start, resource_size(io));
  	if (!p->iomem) {
-		dev_err(&pdev->dev, "failed to remap IOMEM\n");
  		ret = -ENXIO;

   -ENOMEM?

[...]

MBR, Sergei



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux