On Sat, Apr 20, 2019 at 10:41:22AM +0200, Niklas Söderlund wrote: > Hi Laurent and Simon, > > On 2019-04-20 02:30:49 +0300, Laurent Pinchart wrote: > > Hi Niklas, > > > > On Wed, Mar 13, 2019 at 02:46:28PM +0100, Niklas Söderlund wrote: > > > On 2019-03-13 11:51:18 +0100, Simon Horman wrote: > > > > The ports node of vin4 only has one sub-node and thus does > > > > not need #address-cells/#size-cells and the sub-node does > > > > not need an exit. > > > > > > I agree that the warning should be silenced however I have a feeling > > > this might need to be tested. The VIN bindings assigns special meaning > > > to which port reg an endpoint is described in and handles each of them > > > differently, see the biding documentation. > > > > > > As the single port described here is port 0 I think removing the reg > > > property will probably work but is it correct? If someone with a Draak > > > board could test this patch it would be great! > > > > I've tested this patch, and the media-ctl -p output is identical before > > and after applying it. > > > > # media-ctl -p -d /dev/media2 > > Media controller API version 5.1.0 > > > > Media device information > > ------------------------ > > driver rcar_vin > > model renesas,vin-r8a77995 > > serial > > bus info platform:e6ef4000.video > > hw revision 0x0 > > driver version 5.1.0 > > > > Device topology > > - entity 1: adv7180 0-0020 (1 pad, 1 link) > > type V4L2 subdev subtype Decoder flags 0 > > device node name /dev/v4l-subdev6 > > pad0: Source > > [fmt:UYVY8_2X8/720x240 field:alternate] > > -> "VIN4 output":0 [] > > > > - entity 5: VIN4 output (1 pad, 1 link) > > type Node subtype V4L flags 0 > > device node name /dev/video5 > > pad0: Sink > > <- "adv7180 0-0020":0 [] > > > > > > Please let me know if I should conduct other tests. > > Thanks for testing, no more tests are needed. > > > > > Tested-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > It works and the change silence the warning, > > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> Thanks, applied for v5.3.
