Hi Simon,
Thanks for your patch.
On 2019-03-13 11:51:18 +0100, Simon Horman wrote:
> The ports node of vin4 only has one sub-node and thus does
> not need #address-cells/#size-cells and the sub-node does
> not need an exit.
I agree that the warning should be silenced however I have a feeling
this might need to be tested. The VIN bindings assigns special meaning
to which port reg an endpoint is described in and handles each of them
differently, see the biding documentation.
As the single port described here is port 0 I think removing the reg
property will probably work but is it correct? If someone with a Draak
board could test this patch it would be great!
>
> This addresses the following warning:
>
> # make dtbs W=1
> ...
> arch/arm64/boot/dts/renesas/r8a77995-draak.dts:492.8-503.4: Warning (graph_child_address): /soc/video@e6ef4000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
>
> Fixes: 6a0942c20f5c ("arm64: dts: renesas: draak: Describe CVBS input")
> Cc: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
> Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> Developed on top of renesas-devel-20190308-v5.0
> Compile tested only
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> index 244b0dda03ed..8fba6cde5905 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> @@ -490,12 +490,7 @@
> status = "okay";
>
> ports {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - port@0 {
> - reg = <0>;
> -
> + port {
> vin4_in: endpoint {
> remote-endpoint = <&adv7180_out>;
> };
> --
> 2.11.0
>
--
Regards,
Niklas Söderlund
