Hi Biju-san,
> From: Biju Das, Sent: Wednesday, April 10, 2019 7:08 PM
>
> Hi Shimoda-San,
>
> Thanks for the feedback.
>
> > Subject: RE: [PATCH V4 02/13] phy: renesas: phy-rcar-gen2: Add support for
> > r8a77470
> >
> > Hi Biju-san,
> >
> > Thank you for the patch!
> >
> > > From: Biju Das, Sent: Wednesday, April 10, 2019 5:08 PM
> > <snip>
> > > static int rcar_gen2_phy_probe(struct platform_device *pdev) {
> > > struct device *dev = &pdev->dev;
> > > @@ -238,6 +313,8 @@ static int rcar_gen2_phy_probe(struct
> > platform_device *pdev)
> > > struct resource *res;
> > > void __iomem *base;
> > > struct clk *clk;
> > > + const struct phy_ops *gen2_phy_ops = &rcar_gen2_phy_ops;
> > > + const u32 (*select_value)[PHYS_PER_CHANNEL] = pci_select_value;
> > > int i = 0;
> > >
> > > if (!dev->of_node) {
> > > @@ -266,6 +343,11 @@ static int rcar_gen2_phy_probe(struct
> > platform_device *pdev)
> > > drv->clk = clk;
> > > drv->base = base;
> > >
> > > + if (soc_device_match(soc_r8a77470)) {
> >
> > I'm not sure, but this driver also should not use the soc_device_match() like
> > phy-rcar-gen3-usb2 driver?
> > If we add a special data struct and has phy_ops and select_value members,
> > we can achieve not to use the soc_device_match().
>
> There is a difference compared to phy-rcar-gen3-usb2 driver.
> Here we are using generic compatible string for RZ/G1C.
>
> With the new proposal, I need to make following changes.
>
> 1) Add r8a77470 compatible in phy_match table, fill the driver_data structure and remove soc_device_match
I think so.
> 2) Modify the SoC dtsi to remove generic compatible string.
I don't think so. For example, r8a77990.dtsi has compatible with both "renesas,usbhs-r8a77990" and "renesas,rcar-gen3-usbhs",
and then the renesas_usbhs driver has .data for renesas,usbhs-r8a77990, but it is not compatible
with .data of "renesas,rcar-gen3-usbhs".
Simon-san, what do you think?
Best regards,
Yoshihiro Shimoda
> I will send V5 based on new proposal, if you are ok for removing generic compatibility.
> Please let me know.
>
> Regards,
> Biju
>
>
>
