Hi Simon-san, Thank you for your review! > From: Simon Horman, Sent: Wednesday, April 3, 2019 6:21 PM > > Hi Shimoda-san, > > On Mon, Apr 01, 2019 at 09:01:21PM +0900, Yoshihiro Shimoda wrote: > > To have the detailed property on each PHY specifier, this patch revices > > the #phy-cells property. > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > > index ad9c290..7f0d4bf 100644 > > --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > > +++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > > @@ -27,7 +27,12 @@ Required properties: > > > > - reg: offset and length of the partial USB 2.0 Host register block. > > - clocks: clock phandle and specifier pair(s). > > -- #phy-cells: see phy-bindings.txt in the same directory, must be <0>. > > The driver currently supports <0> and with this changeset continues to do > so. I also assume there are existing DTs that use <0>. Would it be > better to describe this as deprecated? I got it. I'll fix this in v2. Best regards, Yoshihiro Shimoda > > +- #phy-cells: see phy-bindings.txt in the same directory, must be <1>. > > + > > +The phandle's argument in the PHY specifier is the INT_STATUS bit of controller: > > +- 1 = USBH_INTA (OHCI) > > +- 2 = USBH_INTB (EHCI) > > +- 3 = UCOM_INT (OTG and BC) > > > > Optional properties: > > To use a USB channel where USB 2.0 Host and HSUSB (USB 2.0 Peripheral) are > > -- > > 2.7.4 > >
