Hello Yoshihiro-san, Thank you for your patch! > From: linux-kernel-owner@xxxxxxxxxxxxxxx <linux-kernel-owner@xxxxxxxxxxxxxxx> On Behalf Of Yoshihiro Shimoda > Sent: 01 April 2019 13:01 > Subject: [PATCH 1/3] dt-bindings: phy: rcar-gen3-phy-usb2: Revise #phy-cells property > > To have the detailed property on each PHY specifier, this patch revices s/revices/revises/g > the #phy-cells property. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > --- > Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt b/Documentation/devicetree/bindings/phy/rcar-gen3- > phy-usb2.txt > index ad9c290..7f0d4bf 100644 > --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > +++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > @@ -27,7 +27,12 @@ Required properties: > > - reg: offset and length of the partial USB 2.0 Host register block. > - clocks: clock phandle and specifier pair(s). > -- #phy-cells: see phy-bindings.txt in the same directory, must be <0>. > +- #phy-cells: see phy-bindings.txt in the same directory, must be <1>. > + > +The phandle's argument in the PHY specifier is the INT_STATUS bit of controller: >From the driver we are also looking for value 0, as in rcar_gen3_get_dr_mode we have a for loop that starts from 0, and we call of_usb_get_dr_mode_by_phy with arg0 == 0, why are we leaving this out from this list? Thanks, Fab > +- 1 = USBH_INTA (OHCI) > +- 2 = USBH_INTB (EHCI) > +- 3 = UCOM_INT (OTG and BC) > > Optional properties: > To use a USB channel where USB 2.0 Host and HSUSB (USB 2.0 Peripheral) are > -- > 2.7.4
