Re: [PATCH 2/5] clk: renesas: rcar-gen3: Correct parent clock of HS-USB

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 27, 2019 at 01:41:37PM +0100, Geert Uytterhoeven wrote:
> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@xxxxxxxxxxx>
> 
> According to the R-Car Gen3 Hardware Manual Rev. 1.00, and the RZ/G2
> Hardware Manual Rev. 0.61, the parent clock of the HS-USB module
> clocks on R-Car Gen3 and RZ/G2 SoCs is S3D2.
> 
> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@xxxxxxxxxxx>
> [takeshi: Update R-Car H3, M3-N, and E3]
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx>
> [geert: Update RZ/G2M and RZ/G2E]
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

During my review I saw that R-Car D3 (r8a77995) is already using the
correct parent clock. And with this change all R-Car Gen3 and RZ/G2 SoCs do
so.

Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>

> ---
>  drivers/clk/renesas/r8a774a1-cpg-mssr.c | 2 +-
>  drivers/clk/renesas/r8a774c0-cpg-mssr.c | 2 +-
>  drivers/clk/renesas/r8a7795-cpg-mssr.c  | 4 ++--
>  drivers/clk/renesas/r8a7796-cpg-mssr.c  | 2 +-
>  drivers/clk/renesas/r8a77965-cpg-mssr.c | 2 +-
>  drivers/clk/renesas/r8a77990-cpg-mssr.c | 2 +-
>  6 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/clk/renesas/r8a774a1-cpg-mssr.c b/drivers/clk/renesas/r8a774a1-cpg-mssr.c
> index bce0e6d6d02c7e7b..676e6a1120900b17 100644
> --- a/drivers/clk/renesas/r8a774a1-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a774a1-cpg-mssr.c
> @@ -167,7 +167,7 @@ static const struct mssr_mod_clk r8a774a1_mod_clks[] __initconst = {
>  	DEF_MOD("vspi0",		 631,	R8A774A1_CLK_S0D1),
>  	DEF_MOD("ehci1",		 702,	R8A774A1_CLK_S3D2),
>  	DEF_MOD("ehci0",		 703,	R8A774A1_CLK_S3D2),
> -	DEF_MOD("hsusb",		 704,	R8A774A1_CLK_S3D4),
> +	DEF_MOD("hsusb",		 704,	R8A774A1_CLK_S3D2),
>  	DEF_MOD("csi20",		 714,	R8A774A1_CLK_CSI0),
>  	DEF_MOD("csi40",		 716,	R8A774A1_CLK_CSI0),
>  	DEF_MOD("du2",			 722,	R8A774A1_CLK_S2D1),
> diff --git a/drivers/clk/renesas/r8a774c0-cpg-mssr.c b/drivers/clk/renesas/r8a774c0-cpg-mssr.c
> index d095787f7d851fc9..c33d3b0370812840 100644
> --- a/drivers/clk/renesas/r8a774c0-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a774c0-cpg-mssr.c
> @@ -179,7 +179,7 @@ static const struct mssr_mod_clk r8a774c0_mod_clks[] __initconst = {
>  	DEF_MOD("vspi0",		 631,	R8A774C0_CLK_S0D1),
>  
>  	DEF_MOD("ehci0",		 703,	R8A774C0_CLK_S3D2),
> -	DEF_MOD("hsusb",		 704,	R8A774C0_CLK_S3D4),
> +	DEF_MOD("hsusb",		 704,	R8A774C0_CLK_S3D2),
>  	DEF_MOD("csi40",		 716,	R8A774C0_CLK_CSI0),
>  	DEF_MOD("du1",			 723,	R8A774C0_CLK_S1D1),
>  	DEF_MOD("du0",			 724,	R8A774C0_CLK_S1D1),
> diff --git a/drivers/clk/renesas/r8a7795-cpg-mssr.c b/drivers/clk/renesas/r8a7795-cpg-mssr.c
> index b9e42da38b72bdcb..5b658b0861180268 100644
> --- a/drivers/clk/renesas/r8a7795-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a7795-cpg-mssr.c
> @@ -199,8 +199,8 @@ static struct mssr_mod_clk r8a7795_mod_clks[] __initdata = {
>  	DEF_MOD("ehci2",		 701,	R8A7795_CLK_S3D2),
>  	DEF_MOD("ehci1",		 702,	R8A7795_CLK_S3D2),
>  	DEF_MOD("ehci0",		 703,	R8A7795_CLK_S3D2),
> -	DEF_MOD("hsusb",		 704,	R8A7795_CLK_S3D4),
> -	DEF_MOD("hsusb3",		 705,	R8A7795_CLK_S3D4),
> +	DEF_MOD("hsusb",		 704,	R8A7795_CLK_S3D2),
> +	DEF_MOD("hsusb3",		 705,	R8A7795_CLK_S3D2),
>  	DEF_MOD("csi21",		 713,	R8A7795_CLK_CSI0), /* ES1.x */
>  	DEF_MOD("csi20",		 714,	R8A7795_CLK_CSI0),
>  	DEF_MOD("csi41",		 715,	R8A7795_CLK_CSI0),
> diff --git a/drivers/clk/renesas/r8a7796-cpg-mssr.c b/drivers/clk/renesas/r8a7796-cpg-mssr.c
> index 97b58f13111441a8..fa1c1ac14d5caa1c 100644
> --- a/drivers/clk/renesas/r8a7796-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a7796-cpg-mssr.c
> @@ -179,7 +179,7 @@ static const struct mssr_mod_clk r8a7796_mod_clks[] __initconst = {
>  	DEF_MOD("vspi0",		 631,	R8A7796_CLK_S0D1),
>  	DEF_MOD("ehci1",		 702,	R8A7796_CLK_S3D2),
>  	DEF_MOD("ehci0",		 703,	R8A7796_CLK_S3D2),
> -	DEF_MOD("hsusb",		 704,	R8A7796_CLK_S3D4),
> +	DEF_MOD("hsusb",		 704,	R8A7796_CLK_S3D2),
>  	DEF_MOD("csi20",		 714,	R8A7796_CLK_CSI0),
>  	DEF_MOD("csi40",		 716,	R8A7796_CLK_CSI0),
>  	DEF_MOD("du2",			 722,	R8A7796_CLK_S2D1),
> diff --git a/drivers/clk/renesas/r8a77965-cpg-mssr.c b/drivers/clk/renesas/r8a77965-cpg-mssr.c
> index ab25bd5f1371869e..48a9add7d4db8975 100644
> --- a/drivers/clk/renesas/r8a77965-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a77965-cpg-mssr.c
> @@ -177,7 +177,7 @@ static const struct mssr_mod_clk r8a77965_mod_clks[] __initconst = {
>  
>  	DEF_MOD("ehci1",		702,	R8A77965_CLK_S3D2),
>  	DEF_MOD("ehci0",		703,	R8A77965_CLK_S3D2),
> -	DEF_MOD("hsusb",		704,	R8A77965_CLK_S3D4),
> +	DEF_MOD("hsusb",		704,	R8A77965_CLK_S3D2),
>  	DEF_MOD("csi20",		714,	R8A77965_CLK_CSI0),
>  	DEF_MOD("csi40",		716,	R8A77965_CLK_CSI0),
>  	DEF_MOD("du3",			721,	R8A77965_CLK_S2D1),
> diff --git a/drivers/clk/renesas/r8a77990-cpg-mssr.c b/drivers/clk/renesas/r8a77990-cpg-mssr.c
> index 3f22b8565648d590..3a88d2247cf5cb17 100644
> --- a/drivers/clk/renesas/r8a77990-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a77990-cpg-mssr.c
> @@ -182,7 +182,7 @@ static const struct mssr_mod_clk r8a77990_mod_clks[] __initconst = {
>  	DEF_MOD("vspi0",		 631,	R8A77990_CLK_S0D1),
>  
>  	DEF_MOD("ehci0",		 703,	R8A77990_CLK_S3D2),
> -	DEF_MOD("hsusb",		 704,	R8A77990_CLK_S3D4),
> +	DEF_MOD("hsusb",		 704,	R8A77990_CLK_S3D2),
>  	DEF_MOD("csi40",		 716,	R8A77990_CLK_CSI0),
>  	DEF_MOD("du1",			 723,	R8A77990_CLK_S1D1),
>  	DEF_MOD("du0",			 724,	R8A77990_CLK_S1D1),
> -- 
> 2.17.1
> 



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux