Hi Laurent, On 2019-03-12 00:10:23 +0200, Laurent Pinchart wrote: > > >> + fld = FLD_FLD_EN4 | FLD_FLD_EN3 | FLD_FLD_EN2 | > > >> FLD_FLD_EN; > > >> + > > >> + if (priv->mf.height == 240) > > >> + fld |= FLD_FLD_NUM(2); > > >> + else > > >> + fld |= FLD_FLD_NUM(1); > > > > > > How does this work ? Looking at the datasheet, I was expecting > > > FLD_DET_SEL field to be set to 01 in order for the field signal to > > > toggle every frame. > > > > I thought so too then I read 26.4.5 FLD Signal which fits what is done > > in the BSP code and fits with how the hardware behaves. > > Do we have a guarantee that all alternate sources will cycle the frame > number between 1 and 2 ? If not I think you should select based on the > LSB. > I can't imagine we have such guarantees and experimenting with FLD_DET_SEL set to 01 one works as expected. I will do so in next version. Thanks for finding this. -- Regards, Niklas Söderlund
