Re: [PATCH] ARM: dts: alt: Add DA9063 PMIC node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/4/19 11:57 AM, Wolfram Sang wrote:
> 
>>> Add DA9063 PMIC node to the I2C bus.
>>>
>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx>
>>
>> Thanks for your patch!
>>
>> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> 
> Thanks for CCing me, I didn't get and missed the original patch.
> 
>>> +++ b/arch/arm/boot/dts/r8a7794-alt.dts
>>> @@ -377,6 +377,27 @@
>>>         pinctrl-names = "i2c-exio4";
>>>  };
>>>
>>> +&i2c7 {
>>> +       status = "okay";
>>> +       clock-frequency = <100000>;
>>
>> According to the DA9063 datasheet, the PMIC supports up to 400 kHz.
>> It looks like there are no other devices on the bus.
>>
>> Wolfram, what's your stance on this?
> 
> Yes, please. I thought this was standard on Gen2 IIC_DVFS busses, but
> seems not. Probably it slipped through the cracks.

Do we want to update all of the other boards too ?

I'd be cautious about the DVFS I2C, running faster while talking to the
PMIC and reading/writing a few registers brings little benefit, while
the signal integrity might be impacted.

-- 
Best regards,
Marek Vasut



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux