Hi Marek, On Sun, Mar 3, 2019 at 8:01 PM <marek.vasut@xxxxxxxxx> wrote: > From: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> > > Add DA9063 PMIC node to the I2C bus. > > Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> Thanks for your patch! Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > --- a/arch/arm/boot/dts/r8a7794-alt.dts > +++ b/arch/arm/boot/dts/r8a7794-alt.dts > @@ -377,6 +377,27 @@ > pinctrl-names = "i2c-exio4"; > }; > > +&i2c7 { > + status = "okay"; > + clock-frequency = <100000>; According to the DA9063 datasheet, the PMIC supports up to 400 kHz. It looks like there are no other devices on the bus. Wolfram, what's your stance on this? > + > + pmic@58 { > + compatible = "dlg,da9063"; > + reg = <0x58>; > + interrupt-parent = <&gpio3>; > + interrupts = <31 IRQ_TYPE_LEVEL_LOW>; > + interrupt-controller; > + > + rtc { > + compatible = "dlg,da9063-rtc"; > + }; > + > + wdt { > + compatible = "dlg,da9063-watchdog"; > + }; > + }; > +}; > + Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds