Hello Geert,
> From: linux-renesas-soc-owner@xxxxxxxxxxxxxxx <linux-renesas-soc-owner@xxxxxxxxxxxxxxx> On Behalf Of Fabrizio Castro
> Sent: 22 February 2019 10:12
> Subject: RE: [PATCH] clk: renesas: r8a774c0: Fix LAST_DT_CORE_CLK
>
> Hello Geert,
>
> > From: linux-renesas-soc-owner@xxxxxxxxxxxxxxx <linux-renesas-soc-owner@xxxxxxxxxxxxxxx> On Behalf Of Geert Uytterhoeven
> > Sent: 21 February 2019 18:34
> > To: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
> > Subject: Re: [PATCH] clk: renesas: r8a774c0: Fix LAST_DT_CORE_CLK
> >
> > On Wed, Feb 20, 2019 at 5:09 PM Fabrizio Castro
> > <fabrizio.castro@xxxxxxxxxxxxxx> wrote:
> > > Enum LAST_DT_CORE_CLK needs updating as R8A774C0_CLK_CANFD
> > > was recently added and it's the core clock with the highest
> > > index.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
> >
> > Nice catch!
> > You only notice this kind of bug when you start referencing the clock
> > from DT, right? At registration time, the clock number space is shared with
> > internal core clocks, so no error is detected.
> > Can we improve that?
>
> I can look into it
Actually, it seems like I am a bit tight on time, not sure I am going to have the chance to look into this, sorry Geert
Thanks,
Fab
>
> >
> > Fixes: 2a6efbc6da5d248c ("clk: renesas: r8a774c0: Add missing CANFD clock")
>
> Commit 2a6efbc6da5d248c is not in a release or in a rc, is it ok to refer to it with a fixes tag?
>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> >
> > Mike/Stephen: can you please take this one directly, as it is a fix for
> > clk-next?
> >
> > Fabrizio: Looks like R8A774A1 has the same bug. Care to fix that as well?
>
> Will do
>
> Thanks,
> Fab
>
> >
> > Thanks!
> >
> > Gr{oetje,eeting}s,
> >
> > Geert
> >
> > --
> > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> >
> > In personal conversations with technical people, I call myself a hacker. But
> > when I'm talking to journalists I just say "programmer" or something like that.
> > -- Linus Torvalds
