On Mon, Jan 28, 2019 at 05:36:39PM +0100, Simon Horman wrote: > On Mon, Jan 28, 2019 at 04:15:30PM +0100, Geert Uytterhoeven wrote: > > Hi Simon, > > > > On Mon, Jan 28, 2019 at 3:05 PM Simon Horman <horms@xxxxxxxxxxxx> wrote: > > > On Tue, Jan 15, 2019 at 09:02:42PM +0900, Yoshihiro Kaneko wrote: > > > > From: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > > > > > > > > This patch define OOP tables for all CPUs. > > > > This allows CPUFreq to function. > > > > > > > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > > > > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> > > > > --- > > > > > > Thanks, I have tested CPUFreq with this tested that with this patch and > > > "[PATCH] clk: renesas: r8a77990: Add Z2 clock" > > > (https://patchwork.kernel.org/patch/10783723/) applied on top of > > > renesas-devel-20190128-v5.0-rc4. > > > > > > Geert, or others, is it expected that z2 does not scale > > > in this test? > > > > Given your patch adds the Z2 clock as a fixed clock, this is expected ;-) > > > > Note that the BSP adds this clock as a programmable clock of type > > CLK_TYPE_GEN3_Z2. > > Thanks, understood. I have now tested this patch in conjunction with "[PATCH v2 0/6] clk: renesas: r8a77990: Add Z2 clock" [1], which implements Z2 as a variable clock, and the results seem substantially better. # cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor performance # cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_available_frequencies 800000 1000000 1200000 # grep . /sys/devices/system/cpu/cpu*/cpufreq/*_cur_freq /sys/kernel/debug/clk/z2/clk_rate /sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_cur_freq:1200000 /sys/devices/system/cpu/cpu0/cpufreq/scaling_cur_freq:1200000 /sys/devices/system/cpu/cpu1/cpufreq/cpuinfo_cur_freq:1200000 /sys/devices/system/cpu/cpu1/cpufreq/scaling_cur_freq:1200000 /sys/kernel/debug/clk/z2/clk_rate:1200000000 # echo 1000000 > /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq # grep . /sys/devices/system/cpu/cpu*/cpufreq/*_cur_freq /sys/kernel/debug/clk/z2/clk_rate /sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_cur_freq:975000 /sys/devices/system/cpu/cpu0/cpufreq/scaling_cur_freq:1000000 /sys/devices/system/cpu/cpu1/cpufreq/cpuinfo_cur_freq:975000 /sys/devices/system/cpu/cpu1/cpufreq/scaling_cur_freq:1000000 /sys/kernel/debug/clk/z2/clk_rate:975000000 # echo 800000 > /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq # grep . /sys/devices/system/cpu/cpu*/cpufreq/*_cur_freq /sys/kernel/debug/clk/z2/clk_rate /sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_cur_freq:787500 /sys/devices/system/cpu/cpu0/cpufreq/scaling_cur_freq:800000 /sys/devices/system/cpu/cpu1/cpufreq/cpuinfo_cur_freq:787500 /sys/devices/system/cpu/cpu1/cpufreq/scaling_cur_freq:800000 /sys/kernel/debug/clk/z2/clk_rate:787500000 # echo 1200000 > /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq grep . /sys/devices/system/cpu/cpu*/cpufreq/*_cur_freq # /sys/kernel/debug/clk/z2/clk_rate /sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_cur_freq:1200000 /sys/devices/system/cpu/cpu0/cpufreq/scaling_cur_freq:1200000 /sys/devices/system/cpu/cpu1/cpufreq/cpuinfo_cur_freq:1200000 /sys/devices/system/cpu/cpu1/cpufreq/scaling_cur_freq:1200000 /sys/kernel/debug/clk/z2/clk_rate:1200000000 Tested-by: Simon Horman <horms+renesas@xxxxxxxxxxxx> [1] https://lore.kernel.org/linux-renesas-soc/20190130094029.9604-1-horms+renesas@xxxxxxxxxxxx/T/#mec59a349508e0be00d3a1d6ef89f838c0e193591
