On 12/14/2018 06:33 PM, Simon Horman wrote: > On Tue, Dec 04, 2018 at 10:49:44PM +0300, Sergei Shtylyov wrote: >> Protect the CPG register read-modify-write sequence with a spinlock. > > Spinlocks are expensive, I think an explanation of why this is > necessary would be worthwhile. The driver using a spinlock to protect the hardware registers is such a common scenario, I didn't think it was worth a special explanation. :-) > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> [...] MBR, Sergei