Hi Simon, On Fri, Dec 14, 2018 at 4:33 PM Simon Horman <horms@xxxxxxxxxxxx> wrote: > On Tue, Dec 04, 2018 at 10:49:44PM +0300, Sergei Shtylyov wrote: > > Protect the CPG register read-modify-write sequence with a spinlock. > > Spinlocks are expensive, I think an explanation of why this is > necessary would be worthwhile. Some clock registers contain bits for multiple clocks. Hence read-modify-write cycles on these registers should be protected against concurrent accesses for multiple clocks. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds