Re: [PATCH] pinctrl: sh-pfc: r8a7778: Fix HSPI pin numbers and names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 16, 2019 at 02:19:23PM +0100, Geert Uytterhoeven wrote:
> When declaring the HSPI RX1_B and TX1_B pins, two mistakes were made:
>   - the rows and columns in the BGA pin matrix, from which the pin
>     numbers are derived, were exchanged,
>   - it was not taken into account that BGA pin row labelling skips
>     characters I, O, Q, and S.
> 
> Fix the order, and the corresponding pin names.
> 
> Notes:
>   - The actual values of the pin numbers don't really matter (they just
>     have to be unique), so the wrong order didn't have any impact,
>   - Changing the names of the pins is user-visible, but there are no
>     users in (upstream) DTS files.
> 
> Fixes: 4f82e3ee724f1712 ("sh-pfc: Support pins not associated with a GPIO port")
> Fixes: 09cc76a95802e87d ("sh-pfc: r8a7778: add HSPI pin groups")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux