On Mon, Jan 07, 2019 at 09:34:02AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Fri, Jan 4, 2019 at 10:04 AM Simon Horman <horms@xxxxxxxxxxxx> wrote:
> > On Wed, Jan 02, 2019 at 11:39:03AM +0100, Geert Uytterhoeven wrote:
> > > On Wed, Jan 2, 2019 at 10:40 AM Simon Horman <horms@xxxxxxxxxxxx> wrote:
> > > > On Fri, Dec 14, 2018 at 04:59:00PM +0100, Simon Horman wrote:
> > > > > On Thu, Dec 13, 2018 at 12:18:46PM +0100, Simon Horman wrote:
> > > > > > On Wed, Dec 12, 2018 at 12:17:11PM +0000, Biju Das wrote:
> > > > > > > The workaround for the wrong hierarchy of the 3DG-{A,B} power domains on
> > > > > > > RZ/G2E ES1.0 corrected the parent domains. However, the 3DG-{A,B} power
> > > > > > > domains were still initialized and powered in the wrong order, causing
> > > > > > > 3DG operation to fail.
> > > > > > >
> > > > > > > Fix this by changing the order in the table at runtime, when running on
> > > > > > > an affected SoC.
> > > > > > >
> > > > > > > This work is based on the work done by Geert for R-Car E3.
> > > > > > >
> > > > > > > Fixes: f37d211c687588328 ("soc: renesas: rcar-sysc: Add r8a774c0 support")
> > > > > > >
> > > > > > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
> > > > > >
> > > > > > Thanks,
> > > > > >
> > > > > > This looks fine to me but I will wait to see if there are other reviews
> > > > > > before applying.
>
> > I have gone ahead and applied this patch for v4.22.
>
> Given commit 1585124d9563da64 ("soc: renesas: rcar-sysc: Merge PM Domain
> registration and linking") is in v5.0-rc1, this means the rcar-sysc driver
> will bail out without this fix, not registering any PM Domains.
> Sorry for not realizing this dependency before.
>
> Hence you may want to queue it as a fix for v5.0 instead.
> Or not, as we won't have a board DTS for RZ/G2E in v5.0-rc1 anyway?
Thanks, it seems appropriate for this to be a fix for v5.0.
I've updated my branches accordingly.
