Hi Simon, Thanks for the feedback. > -----Original Message----- > From: linux-renesas-soc-owner@xxxxxxxxxxxxxxx <linux-renesas-soc- > owner@xxxxxxxxxxxxxxx> On Behalf Of Simon Horman > Sent: 02 January 2019 09:40 > To: Biju Das <biju.das@xxxxxxxxxxxxxx> > Cc: Magnus Damm <magnus.damm@xxxxxxxxx>; linux-renesas- > soc@xxxxxxxxxxxxxxx; Geert Uytterhoeven <geert+renesas@xxxxxxxxx>; > Chris Paterson <Chris.Paterson2@xxxxxxxxxxx>; Fabrizio Castro > <fabrizio.castro@xxxxxxxxxxxxxx> > Subject: Re: [PATCH] soc: renesas: r8a774c0-sysc: Fix initialization order of > 3DG-{A,B} > > On Fri, Dec 14, 2018 at 04:59:00PM +0100, Simon Horman wrote: > > On Thu, Dec 13, 2018 at 12:18:46PM +0100, Simon Horman wrote: > > > On Wed, Dec 12, 2018 at 12:17:11PM +0000, Biju Das wrote: > > > > The workaround for the wrong hierarchy of the 3DG-{A,B} power > > > > domains on RZ/G2E ES1.0 corrected the parent domains. However, the > > > > 3DG-{A,B} power domains were still initialized and powered in the > > > > wrong order, causing 3DG operation to fail. > > > > > > > > Fix this by changing the order in the table at runtime, when > > > > running on an affected SoC. > > > > > > > > This work is based on the work done by Geert for R-Car E3. > > > > > > > > Fixes: f37d211c687588328 ("soc: renesas: rcar-sysc: Add r8a774c0 > > > > support") > > > > > > > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx> > > > > > > Thanks, > > > > > > This looks fine to me but I will wait to see if there are other > > > reviews before applying. > > > > > > Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx> > > > > Thanks, v2 sent. > > > > I don't see a v2 or any other review of this patch. > Am I missing something? I guess you have sent v2, https://patchwork.kernel.org/patch/10731381/ based on https://patchwork.kernel.org/patch/10726065/ regards, Biju Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.